feat(dex): use postgresql as backend #839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoGoman
reviewed
Jan 15, 2025
cmd/greenhouse/main.go
Outdated
Comment on lines
97
to
101
| flag.StringVar(&pgDB, "database", os.Getenv("DB_NAME"), "Database name") | ||
| flag.StringVar(&pgHost, "dbHost", os.Getenv("DB_HOST"), "Database host") | ||
| flag.Uint16Var(&pgPort, "dbPort", 5432, "Database port") | ||
| flag.StringVar(&pgUser, "dbUser", os.Getenv("DB_USER"), "Database user") | ||
| flag.StringVar(&pgPasswd, "dbPassword", os.Getenv("DB_PASSWORD"), "Database password") |
There was a problem hiding this comment.
The description is quite broad. I think in this case we can make it more specific and prefix with Dex e.g. "Dex Database name". Just to avoid confusion on what the DB is for.
There was a problem hiding this comment.
Isn’t it better if these credentials came from a secret instead of args? The deployment can then set it as env variables instead.
The connection to DB can be opened during appStart / main and the client can be passed along.
There was a problem hiding this comment.
done, the password would come from a secret, but since the underlying helm chart is not yet uploaded I can not include it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist